Skip to content

Make --recon-spec a required argument#375

Merged
tsalo merged 1 commit intomainfrom
recon-spec-required
Apr 15, 2026
Merged

Make --recon-spec a required argument#375
tsalo merged 1 commit intomainfrom
recon-spec-required

Conversation

@tsalo
Copy link
Copy Markdown
Member

@tsalo tsalo commented Apr 14, 2026

Closes #374.

Changes proposed in this pull request

  • Make --recon-spec required.
  • Fix outdated help string for --recon-spec (we use YAMLs instead of JSONs now).
  • Note in --config-file's help string that it is currently not used.

@tsalo tsalo added the bug Something isn't working label Apr 14, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.44%. Comparing base (06cfe29) to head (713c332).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   50.44%   50.44%           
=======================================
  Files          55       55           
  Lines        8139     8139           
  Branches      944      944           
=======================================
  Hits         4106     4106           
  Misses       3794     3794           
  Partials      239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo requested review from mattcieslak April 14, 2026 14:35
@tsalo
Copy link
Copy Markdown
Member Author

tsalo commented Apr 15, 2026

Offline approval from @mattcieslak.

@tsalo tsalo merged commit 6a7a93f into main Apr 15, 2026
26 checks passed
@tsalo tsalo deleted the recon-spec-required branch April 15, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running QSIRecon without a recon-spec raises a confusing error

3 participants